- Jul 04, 2010
-
-
Wolfgang Denk authored
The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char *argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char * const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char **argv) { while (--argc > 0 && **++argv == '-') { /* ====> */ while (*++*argv) { switch (**argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location '*argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && **++argv == '-') { char *arg = *argv; while (*++arg) { switch (*arg) { ... Signed-off-by:
Wolfgang Denk <wd@denx.de> Acked-by:
Mike Frysinger <vapier@gentoo.org>
-
- Oct 03, 2009
-
-
Peter Tyser authored
The more standard 'source' command provides identical functionality to the autoscr command. Environment variable names/values on the MVBC_P, MVBML7, kmeter1, mgcoge, and km8xx boards are updated to no longer refernce 'autoscr'. The 'autoscript' and 'autoscript_uname' environment variables are also removed. Signed-off-by:
Peter Tyser <ptyser@xes-inc.com> Acked-by:
Andre Schwarz <andre.schwarz@matrix-vision.de> Acked-by:
Heiko Schocher <hs@denx.de>
-
- Sep 22, 2009
-
-
Peter Tyser authored
The more standard 'source' command provides identical functionality to the autoscr command. Environment variable names/values on the MVBC_P, MVBML7, kmeter1, mgcoge, and km8xx boards are updated to no longer refernce 'autoscr'. The 'autoscript' and 'autoscript_uname' environment variables are also removed. Signed-off-by:
Peter Tyser <ptyser@xes-inc.com> Acked-by:
Andre Schwarz <andre.schwarz@matrix-vision.de> Acked-by:
Heiko Schocher <hs@denx.de>
-
- Jun 12, 2009
-
-
Wolfgang Denk authored
Many of the help messages were not really helpful; for example, many commands that take no arguments would not print a correct synopsis line, but "No additional help available." which is not exactly wrong, but not helpful either. Commit ``Make "usage" messages more helpful.'' changed this partially. But it also became clear that lots of "Usage" and "Help" messages (fields "usage" and "help" in struct cmd_tbl_s respective) were actually redundant. This patch cleans this up - for example: Before: => help dtt dtt - Digital Thermometer and Thermostat Usage: dtt - Read temperature from digital thermometer and thermostat. After: => help dtt dtt - Read temperature from Digital Thermometer and Thermostat Usage: dtt Signed-off-by:
Wolfgang Denk <wd@denx.de>
-
- Apr 03, 2009
-
-
Wolfgang Denk authored
According to the doc/feature-removal-schedule.txt, the "autoscr" command will be replaced by the "source" command in approximately 6 months from now. This patch prepares this change and starts a 6 month transition period as follows: - The new "source" command has been added, which implements exactly the same functionlaity as the old "autoscr" command before - The old "autoscr" command name is kept as an alias for compatibility - Command sequences, script files atc. have been adapted to use the new "source" command - Related environment variables ("autoscript", "autoscript_uname") have *not* been adapted yet; these will be renamed resp. removed in a separate patch when the support for the "autoscr" command get's finally dropped. Signed-off-by:
Wolfgang Denk <wd@denx.de>
-
- Jan 28, 2009
-
-
Peter Tyser authored
Remove command name from all command "usage" fields and update common/command.c to display "name - usage" instead of just "usage". Also remove newlines from command usage fields. Signed-off-by:
Peter Tyser <ptyser@xes-inc.com>
-
- Oct 18, 2008
-
-
Jean-Christophe PLAGNIOL-VILLARD authored
Signed-off-by:
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
-
- Sep 10, 2008
-
-
Petri Lehtinen authored
When not using hush, the autoscr command now executes lines that are only one character long. It also runs the last line of scripts even if it does not end in a newline. Signed-off-by:
Petri Lehtinen <petri.lehtinen@inoi.fi>
-
- Aug 29, 2008
-
-
Jean-Christophe PLAGNIOL-VILLARD authored
Signed-off-by:
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
-
- May 20, 2008
-
-
Wolfgang Denk authored
This commit gets rid of a huge amount of silly white-space issues. Especially, all sequences of SPACEs followed by TAB characters get removed (unless they appear in print statements). Also remove all embedded "vim:" and "vi:" statements which hide indentation problems. Signed-off-by:
Wolfgang Denk <wd@denx.de>
-
- Apr 24, 2008
-
-
Bartlomiej Sieka authored
As suggested by Wolfgang Denk: - image printing functions: - remove wrappers - remove indentation prefix from functions' signatures - merge getenv_verify and getenv_autostart into one parametrized function Signed-off-by:
Bartlomiej Sieka <tur@semihalf.com>
-
- Mar 20, 2008
-
-
Bartlomiej Sieka authored
Signed-off-by:
Bartlomiej Sieka <tur@semihalf.com>
-
- Mar 12, 2008
-
-
Marian Balakowicz authored
autoscript() routine is updated to accept second argument, which is only used for FIT images and provides a FIT subimage unit name. autoscript() routine callers must now pass two arguments. For non-interactive use (like in cmd_load.c, cmd_net.c), new environment variable 'autoscript_uname' is introduced and used as a FIT subimage unit name source. autoscript command accepts extended syntax of the addr argument: addr:<subimg_uname> Signed-off-by:
Marian Balakowicz <m8@semihalf.com>
-
- Feb 29, 2008
-
-
Marian Balakowicz authored
This patch introduces the following prefix convention for the image format handling and bootm related code: genimg_ - dual format shared code image_ - legacy uImage format specific code fit_ - new uImage format specific code boot_ - booting process related code Related routines are renamed and a few pieces of code are moved around and re-grouped. Signed-off-by:
Marian Balakowicz <m8@semihalf.com>
-
- Feb 25, 2008
-
-
Marian Balakowicz authored
This patch adds framework for dual format images. Format detection is added and the bootm controll flow is updated to include cases for new FIT format uImages. When the legacy (image_header based) format is detected appropriate legacy specific handling is invoked. For the new (FIT based) format uImages dual boot framework has a minial support, that will only print out a corresponding debug messages. Implementation of the FIT specific handling will be added in following patches. Signed-off-by:
Marian Balakowicz <m8@semihalf.com>
-
- Feb 07, 2008
-
-
Marian Balakowicz authored
- use single image header pointer instead of a set of auxilliary variables. - add multi component image helper routines: get component size/data address Signed-off-by:
Marian Balakowicz <m8@semihalf.com>
-
Marian Balakowicz authored
- Add inline helper macros for basic header processing - Move common non inline code common/image.c - Replace direct header access with the API routines - Rename IH_CPU_* to IH_ARCH_* Signed-off-by:
Marian Balakowicz <m8@semihalf.com>
-
- Jul 10, 2007
-
-
Jon Loeliger authored
Fixed some broken instances of "#ifdef CMD_CFG_IDE" too. Those always evaluated TRUE, and thus were always compiled even when IDE really wasn't defined/wanted. Signed-off-by:
Jon Loeliger <jdl@freescale.com>
-
- Jul 08, 2007
-
-
Jon Loeliger authored
Signed-off-by:
Jon Loeliger <jdl@freescale.com>
-
- Jul 03, 2007
-
-
Jon Loeliger authored
This is a compatibility step that allows both the older form and the new form to co-exist for a while until the older can be removed entirely. All transformations are of the form: Before: #if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) After: #if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) || defined(CONFIG_CMD_AUTOSCRIPT) Signed-off-by:
Jon Loeliger <jdl@freescale.com>
-
- Oct 13, 2005
-
-
Wolfgang Denk authored
-
- Mar 23, 2004
-
-
Wolfgang Denk authored
- show PCI clock frequency on MPC8260 systems - add FCC_PSMR_RMII flag for HiP7 processors - in do_jffs2_fsload(), take load address from load_addr if not set explicit, update load_addr otherwise - replaced printf by putc/puts when no formatting is needed (smaller code size, faster execution)
-
- Jul 01, 2003
-
-
Wolfgang Denk authored
get rid of MK_CMD_ENTRY macro; update doc/README.command
-
- Jun 29, 2003
-
-
Wolfgang Denk authored
(autoscript, bmp, bsp, fat, mmc, nand, portio, ...)
-
- Jun 27, 2003
-
-
Wolfgang Denk authored
- remove trailing white space, trailing empty lines, C++ comments, etc. - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c) * Patches by Kenneth Johansson, 25 Jun 2003: - major rework of command structure (work done mostly by Michal Cendrowski and Joakim Kristiansen)
-
- Nov 03, 2002
-
-
Wolfgang Denk authored
seconds instead of ms. * Patch by Robert Schwebel, 1 Nov 2002: XScale related cleanup (affects all ARM boards) * Cleanup of names, warnings and README.
-
- Oct 20, 2002
-
-
Wolfgang Denk authored
-