Skip to content
Snippets Groups Projects
  1. Apr 20, 2011
    • Andy Fleming's avatar
      fsl: Change fsl_phy_enet_if to phy_interface_t · 865ff856
      Andy Fleming authored
      
      The fsl_phy_enet_if enum was, essentially, the phy_interface_t enum.
      This meant that drivers which used fsl_phy_enet_if to deal with
      PHY interfaces would have to convert between the two (or we would have
      to have them mirror each other, and deal with the ensuing maintenance
      headache). Instead, we switch all clients of fsl_phy_enet_if over to
      phy_interface_t, which should become the standard, anyway.
      
      Signed-off-by: default avatarAndy Fleming <afleming@freescale.com>
      Acked-by: default avatarDetlev Zundel <dzu@denx.de>
      865ff856
    • Andy Fleming's avatar
      Remove instances of phy_read/write · 09c04c20
      Andy Fleming authored
      
      There were a few files which were already using phy_read and phy_write
      for their PHY function names.  It's only a few places, and the name
      seems most appropriate for the high-level abstraction, so let's
      rename the other versions to something more specific.
      
      Also, uec_phy.c had a marvell_init function which I renamed to not
      conflict with the one in marvell.c
      
      Lastly, uec_phy.c was putting a space between the phy writing
      function names, and the open paren, so I fixed that
      
      Signed-off-by: default avatarAndy Fleming <afleming@freescale.com>
      Acked-by: default avatarDetlev Zundel <dzu@denx.de>
      09c04c20
  2. Apr 05, 2011
  3. Jan 25, 2011
    • Kumar Gala's avatar
      UEC: Fix compiler warnings introduced by linux/mii.h change · 2b21ec92
      Kumar Gala authored
      
      Patch 8ef583a0 [miiphy: convert to linux/mii.h] introduced the following
      compiler warnings in the uec ethernet driver:
      
      In file included from /local/home/galak/git/u-boot-85xx/include/miiphy.h:37:0,
                       from uec.c:32:
      /local/home/galak/git/u-boot-85xx/include/linux/mii.h:133:0: warning: "LPA_1000FULL" redefined
      uec_phy.h:34:0: note: this is the location of the previous definition
      /local/home/galak/git/u-boot-85xx/include/linux/mii.h:134:0: warning: "LPA_1000HALF" redefined
      uec_phy.h:35:0: note: this is the location of the previous definition
      In file included from /local/home/galak/git/u-boot-85xx/include/miiphy.h:37:0,
                       from uec_phy.c:27:
      /local/home/galak/git/u-boot-85xx/include/linux/mii.h:133:0: warning: "LPA_1000FULL" redefined
      uec_phy.h:34:0: note: this is the location of the previous definition
      /local/home/galak/git/u-boot-85xx/include/linux/mii.h:134:0: warning: "LPA_1000HALF" redefined
      uec_phy.h:35:0: note: this is the location of the previous definition
      
      Fix them be removing the duplication in the uec code and utlizing the
      linux/mii.h version instead.
      
      Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
      2b21ec92
  4. Jan 09, 2011
  5. Nov 18, 2010
  6. Nov 17, 2010
    • Sebastien Carlier's avatar
      Switch from archive libraries to partial linking · 6d8962e8
      Sebastien Carlier authored
      
      Before this commit, weak symbols were not overridden by non-weak symbols
      found in archive libraries when linking with recent versions of
      binutils.  As stated in the System V ABI, "the link editor does not
      extract archive members to resolve undefined weak symbols".
      
      This commit changes all Makefiles to use partial linking (ld -r) instead
      of creating library archives, which forces all symbols to participate in
      linking, allowing non-weak symbols to override weak symbols as intended.
      This approach is also used by Linux, from which the gmake function
      cmd_link_o_target (defined in config.mk and used in all Makefiles) is
      inspired.
      
      The name of each former library archive is preserved except for
      extensions which change from ".a" to ".o".  This commit updates
      references accordingly where needed, in particular in some linker
      scripts.
      
      This commit reveals board configurations that exclude some features but
      include source files that depend these disabled features in the build,
      resulting in undefined symbols.  Known such cases include:
      - disabling CMD_NET but not CMD_NFS;
      - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
      
      Signed-off-by: default avatarSebastien Carlier <sebastien.carlier@gmail.com>
      6d8962e8
  7. Oct 20, 2010
  8. Oct 12, 2010
  9. Aug 09, 2010
  10. Jul 24, 2010
  11. Jul 04, 2010
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  12. May 03, 2010
  13. Apr 21, 2010
  14. Apr 13, 2010
  15. Feb 01, 2010
  16. Oct 27, 2009
  17. Sep 25, 2009
  18. Aug 10, 2009
  19. Jul 07, 2009
  20. Jun 12, 2009
  21. Apr 04, 2009
  22. Mar 30, 2009
  23. Jan 28, 2009
  24. Jan 25, 2009
  25. Nov 10, 2008
  26. Oct 18, 2008
Loading