Skip to content
Snippets Groups Projects
Select Git revision
  • vesta-500-mfg
  • master default protected
  • launch-ddr-stress-test
  • one_ring
  • expansion-board-nor
  • norflash-64M
6 results
Search by author
  • Any Author
  • Chris Mills Chris Mills millsc
  • David Mondou David Mondou mondoud
  • Donald Chen Donald Chen chend
  • EJ Finneran EJ Finneran EJ.Finneran
  • Eric Stutzenberger Eric Stutzenberger stutzenbergere
  • Johnnie Peters Johnnie Peters petersj
  • Jussi Ylanen Jussi Ylanen ylanenj
  • Justin Rigling Justin Rigling riglingj
  • Matthew Hawks Matthew Hawks hawksm
  • Nick Conroy Nick Conroy conroyn
  • Paul J. Briskey Paul J. Briskey briskeyp
  • Peter Bliss Peter Bliss peter.bliss
  • Spyder McHenry Spyder McHenry mchenrys
13 authors
  1. Aug 20, 2010
  3. Jul 12, 2010
  5. Jul 04, 2010
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored 
      
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  7. May 28, 2010
  9. Apr 24, 2010
  11. Apr 16, 2010
  13. Apr 13, 2010