Skip to content
Snippets Groups Projects
  1. Oct 15, 2011
  2. Apr 29, 2011
    • Scott Wood's avatar
      Handle most LDSCRIPT setting centrally · 83b7e2a7
      Scott Wood authored
      
      Currently, some linker scripts are found by common code in config.mk.
      Some are found using CONFIG_SYS_LDSCRIPT, but the code for that is
      sometimes in arch config.mk and sometimes in board config.mk.  Some
      are found using an arch-specific rule for looking in CPUDIR, etc.
      
      Further, the powerpc config.mk rule relied on CONFIG_NAND_SPL
      when it really wanted CONFIG_NAND_U_BOOT -- which covered up the fact
      that not all NAND_U_BOOT builds actually wanted CPUDIR/u-boot-nand.lds.
      
      Replace all of this -- except for a handful of boards that are actually
      selecting a linker script in a unique way -- with centralized ldscript
      finding.
      
      If board code specifies LDSCRIPT, that will be used.
      Otherwise, if CONFIG_SYS_LDSCRIPT is specified, that will be used.
      
      If neither of these are specified, then the central config.mk will
      check for the existence of the following, in order:
      
      $(TOPDIR)/board/$(BOARDDIR)/u-boot-nand.lds (only if CONFIG_NAND_U_BOOT)
      $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds (only if CONFIG_NAND_U_BOOT)
      $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds
      $(TOPDIR)/$(CPUDIR)/u-boot.lds
      
      Some boards (sc3, cm5200, munices) provided their own u-boot.lds that
      were dead code, because they were overridden by a CPUDIR u-boot.lds under
      the old powerpc rules.  These boards' own u-boot.lds have bitrotted and
      no longer work -- these lds files have been removed.
      
      Signed-off-by: default avatarScott Wood <scottwood@freescale.com>
      Tested-by: default avatarGraeme Russ <graeme.russ@gmail.com>
      83b7e2a7
  3. Mar 27, 2011
  4. Nov 28, 2010
  5. Nov 17, 2010
    • Sebastien Carlier's avatar
      Switch from archive libraries to partial linking · 6d8962e8
      Sebastien Carlier authored
      
      Before this commit, weak symbols were not overridden by non-weak symbols
      found in archive libraries when linking with recent versions of
      binutils.  As stated in the System V ABI, "the link editor does not
      extract archive members to resolve undefined weak symbols".
      
      This commit changes all Makefiles to use partial linking (ld -r) instead
      of creating library archives, which forces all symbols to participate in
      linking, allowing non-weak symbols to override weak symbols as intended.
      This approach is also used by Linux, from which the gmake function
      cmd_link_o_target (defined in config.mk and used in all Makefiles) is
      inspired.
      
      The name of each former library archive is preserved except for
      extensions which change from ".a" to ".o".  This commit updates
      references accordingly where needed, in particular in some linker
      scripts.
      
      This commit reveals board configurations that exclude some features but
      include source files that depend these disabled features in the build,
      resulting in undefined symbols.  Known such cases include:
      - disabling CMD_NET but not CMD_NFS;
      - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
      
      Signed-off-by: default avatarSebastien Carlier <sebastien.carlier@gmail.com>
      6d8962e8
  6. Oct 18, 2010
  7. Sep 21, 2010
    • Michael Zaidman's avatar
      POST cleanup. · 800eb096
      Michael Zaidman authored
      
      - Revives POST for blackfin arch;
      - Removes redundant code:
           arch/blackfin/lib/post.c
           arch/powerpc/cpu/ppc4xx/commproc.c
           arch/powerpc/cpu/mpc512x/common.c
      - fixes up the post_word_{load|store} usage.
      
      Signed-off-by: default avatarMichael Zaidman <michael.zaidman@gmail.com>
      Acked-by: default avatarDetlev Zundel <dzu@denx.de>
      Tested-by: default avatarAnatolij Gustschin <agust@denx.de>
      
      List of the maintainers of the affected by patch boards:
      Cc: Stephan Linz <linz@li-pro.net>
      Cc: Denis Peter <d.peter@mpl.ch>
      Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
      Cc: Peter Tyser <ptyser@xes-inc.com>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Mike Frysinger <vapier@gentoo.org>
      Cc: Niklaus Giger <niklaus.giger@netstal.com>
      Cc: Larry Johnson <lrj@acm.org>
      Cc: Feng Kan <fkan@amcc.com>
      800eb096
  8. Jul 04, 2010
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  9. Apr 21, 2010
  10. Apr 13, 2010
  11. Dec 08, 2009
  12. Dec 07, 2009
    • Stefan Roese's avatar
      POST: Remove duplicated post_hotkey_pressed() functions · 39ff7d5f
      Stefan Roese authored
      
      This patch introduces a weak default function for post_hotkey_pressed(),
      returning 0, for boards without hotkey support. The long-running tests
      won't be started on those boards. This default function was implemented
      in many board directories. By implementing this weak default we can
      remove all those duplicate versions.
      
      Boards with hotkey support, can override this weak default function
      by defining one in their board specific code.
      
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      39ff7d5f
  13. Oct 03, 2009
    • Peter Tyser's avatar
      ppc: Enable full relocation to RAM · 85829017
      Peter Tyser authored
      
      The following changes allow U-Boot to fully relocate from flash to
      RAM:
       - Remove linker scripts' .fixup sections from the .text section
       - Add -mrelocatable to PLATFORM_RELFLAGS for all boards
       - Define CONFIG_RELOC_FIXUP_WORKS for all boards
      
      Previously, U-Boot would partially relocate, but statically initialized
      pointers needed to be manually relocated.
      
      Signed-off-by: default avatarPeter Tyser <ptyser@xes-inc.com>
      85829017
  14. Jun 12, 2009
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
    • Peter Tyser's avatar
      cm5200: Make function test command names more unique · 8229e9c0
      Peter Tyser authored
      
      Add "_test" to cm5200's function test command names to prevent
      overlap with common, global function names.  Originally, the
      "do_i2c" function test command interfered with
      common/cmd_i2c.c's "do_i2c" when CONFIG_I2C_CMD_TREE was defined.
      
      The functions were also made static as they are not globally accessed.
      
      Signed-off-by: default avatarPeter Tyser <ptyser@xes-inc.com>
      8229e9c0
  15. Mar 20, 2009
    • Trent Piepho's avatar
      Fix all linker script to handle all rodata sections · f62fb999
      Trent Piepho authored
      
      A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
      which needs to be added the the linker script.  Instead of just adding this
      one section, we use a wildcard ".rodata*" to get all rodata linker section
      gcc has now and might add in the future.
      
      However, '*(.rodata*)' by itself will result in sub-optimal section
      ordering.  The sections will be sorted by object file, which causes extra
      padding between the unaligned rodata.str.1.1 of one object file and the
      aligned rodata of the next object file.  This is easy to fix by using the
      SORT_BY_ALIGNMENT command.
      
      This patch has not be tested one most of the boards modified.  Some boards
      have a linker script that looks something like this:
      
      *(.text)
      . = ALIGN(16);
      *(.rodata)
      *(.rodata.str1.4)
      *(.eh_frame)
      
      I change this to:
      
      *(.text)
      . = ALIGN(16);
      *(.eh_frame)
      *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
      
      This means the start of rodata will no longer be 16 bytes aligned.
      However, the boundary between text and rodata/eh_frame is still aligned to
      16 bytes, which is what I think the real purpose of the ALIGN call is.
      
      Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
      f62fb999
  16. Jan 28, 2009
  17. Nov 18, 2008
  18. Oct 18, 2008
  19. Jul 10, 2008
  20. Jul 09, 2008
  21. Jul 02, 2008
  22. Jun 12, 2008
    • Becky Bruce's avatar
      Change initdram() return type to phys_size_t · 9973e3c6
      Becky Bruce authored
      
      This patch changes the return type of initdram() from long int to phys_size_t.
      This is required for a couple of reasons: long int limits the amount of dram
      to 2GB, and u-boot in general is moving over to phys_size_t to represent the
      size of physical memory.  phys_size_t is defined as an unsigned long on almost
      all current platforms.
      
      This patch *only* changes the return type of the initdram function (in
      include/common.h, as well as in each board's implementation of initdram).  It
      does not actually modify the code inside the function on any of the platforms;
      platforms which wish to support more than 2GB of DRAM will need to modify
      their initdram() function code.
      
      Build tested with MAKEALL for ppc, arm, mips, mips-el. Booted on powerpc
      MPC8641HPCN.
      
      Signed-off-by: default avatarBecky Bruce <becky.bruce@freescale.com>
      9973e3c6
  23. May 20, 2008
    • Wolfgang Denk's avatar
      Big white-space cleanup. · 53677ef1
      Wolfgang Denk authored
      
      This commit gets rid of a huge amount of silly white-space issues.
      Especially, all sequences of SPACEs followed by TAB characters get
      removed (unless they appear in print statements).
      
      Also remove all embedded "vim:" and "vi:" statements which hide
      indentation problems.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      53677ef1
  24. Apr 18, 2008
  25. Feb 22, 2008
  26. Jan 12, 2008
    • Wolfgang Denk's avatar
      Fix linker scripts: add NOLOAD atribute to .bss/.sbss sections · 64134f01
      Wolfgang Denk authored
      
      With recent toolchain versions, some boards would not build because
      or errors like this one (here for ocotea board when building with
      ELDK 4.2 beta):
      ppc_4xx-ld: section .bootpg [fffff000 -> fffff23b] overlaps section .bss [fffee900 -> fffff8ab]
      
      For many boards, the .bss section is big enough that it wraps around
      at the end of the address space (0xFFFFFFFF), so the problem will not
      be visible unless you use a 64 bit tool chain for development. On
      some boards however, changes to the code size (due to different
      optimizations) we bail out with section overlaps like above.
      
      The fix is to add the NOLOAD attribute to the .bss and .sbss
      sections, telling the linker that .bss does not consume any space in
      the image.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      64134f01
  27. Dec 08, 2007
  28. Nov 21, 2007
  29. Oct 05, 2007
  30. Sep 13, 2007
  31. Aug 13, 2007
  32. Aug 12, 2007
  33. Aug 03, 2007
Loading