Skip to content
Snippets Groups Projects
  1. Oct 15, 2011
  2. May 12, 2011
    • Wolfgang Denk's avatar
      Fix incorrect use of getenv() before relocation · f0c0b3a9
      Wolfgang Denk authored
      
      A large number of boards incorrectly used getenv() in their board init
      code running before relocation.  In some cases this caused U-Boot to
      hang when certain environment variables grew too long.
      Fix the code to use getenv_r().
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Cc: Stefan Roese <sr@denx.de>
      Cc: The LEOX team <team@leox.org>
      Cc: Michael Schwingen <michael@schwingen.org>
      Cc: Georg Schardt <schardt@team-ctech.de>
      Cc: Werner Pfister <Pfister_Werner@intercontrol.de>
      Cc: Dirk Eibach <eibach@gdsys.de>
      Cc: Peter De Schrijver <p2@mind.be>
      Cc: John Zhan <zhanz@sinovee.com>
      Cc: Rishi Bhattacharya <rishi@ti.com>
      Cc: Peter Tyser <ptyser@xes-inc.com>
      f0c0b3a9
  3. Apr 20, 2011
  4. Mar 27, 2011
  5. Dec 09, 2010
  6. Nov 27, 2010
  7. Nov 17, 2010
    • Sebastien Carlier's avatar
      Switch from archive libraries to partial linking · 6d8962e8
      Sebastien Carlier authored
      
      Before this commit, weak symbols were not overridden by non-weak symbols
      found in archive libraries when linking with recent versions of
      binutils.  As stated in the System V ABI, "the link editor does not
      extract archive members to resolve undefined weak symbols".
      
      This commit changes all Makefiles to use partial linking (ld -r) instead
      of creating library archives, which forces all symbols to participate in
      linking, allowing non-weak symbols to override weak symbols as intended.
      This approach is also used by Linux, from which the gmake function
      cmd_link_o_target (defined in config.mk and used in all Makefiles) is
      inspired.
      
      The name of each former library archive is preserved except for
      extensions which change from ".a" to ".o".  This commit updates
      references accordingly where needed, in particular in some linker
      scripts.
      
      This commit reveals board configurations that exclude some features but
      include source files that depend these disabled features in the build,
      resulting in undefined symbols.  Known such cases include:
      - disabling CMD_NET but not CMD_NFS;
      - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
      
      Signed-off-by: default avatarSebastien Carlier <sebastien.carlier@gmail.com>
      6d8962e8
  8. Oct 18, 2010
    • Wolfgang Denk's avatar
      Makefile: move all Power Architecture boards into boards.cfg · 2ae18241
      Wolfgang Denk authored
      
      Clean up Makefile, and drop a lot of the config.mk files on the way.
      
      We now also automatically pick all boards that are listed in
      boards.cfg (and with all configurations), so we can drop the redundant
      entries from MAKEALL to avoid building these twice.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      2ae18241
    • Wolfgang Denk's avatar
      Rename TEXT_BASE into CONFIG_SYS_TEXT_BASE · 14d0a02a
      Wolfgang Denk authored
      
      The change is currently needed to be able to remove the board
      configuration scripting from the top level Makefile and replace it by
      a simple, table driven script.
      
      Moving this configuration setting into the "CONFIG_*" name space is
      also desirable because it is needed if we ever should move forward to
      a Kconfig driven configuration system.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      14d0a02a
  9. Sep 23, 2010
  10. Jul 04, 2010
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  11. Apr 21, 2010
  12. Apr 13, 2010
  13. Nov 02, 2009
  14. Oct 03, 2009
    • Peter Tyser's avatar
      ppc: Enable full relocation to RAM · 85829017
      Peter Tyser authored
      
      The following changes allow U-Boot to fully relocate from flash to
      RAM:
       - Remove linker scripts' .fixup sections from the .text section
       - Add -mrelocatable to PLATFORM_RELFLAGS for all boards
       - Define CONFIG_RELOC_FIXUP_WORKS for all boards
      
      Previously, U-Boot would partially relocate, but statically initialized
      pointers needed to be manually relocated.
      
      Signed-off-by: default avatarPeter Tyser <ptyser@xes-inc.com>
      85829017
  15. Jun 12, 2009
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
  16. Mar 20, 2009
    • Trent Piepho's avatar
      Fix all linker script to handle all rodata sections · f62fb999
      Trent Piepho authored
      
      A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
      which needs to be added the the linker script.  Instead of just adding this
      one section, we use a wildcard ".rodata*" to get all rodata linker section
      gcc has now and might add in the future.
      
      However, '*(.rodata*)' by itself will result in sub-optimal section
      ordering.  The sections will be sorted by object file, which causes extra
      padding between the unaligned rodata.str.1.1 of one object file and the
      aligned rodata of the next object file.  This is easy to fix by using the
      SORT_BY_ALIGNMENT command.
      
      This patch has not be tested one most of the boards modified.  Some boards
      have a linker script that looks something like this:
      
      *(.text)
      . = ALIGN(16);
      *(.rodata)
      *(.rodata.str1.4)
      *(.eh_frame)
      
      I change this to:
      
      *(.text)
      . = ALIGN(16);
      *(.eh_frame)
      *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
      
      This means the start of rodata will no longer be 16 bytes aligned.
      However, the boundary between text and rodata/eh_frame is still aligned to
      16 bytes, which is what I think the real purpose of the ALIGN call is.
      
      Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
      f62fb999
  17. Feb 07, 2009
  18. Jan 28, 2009
  19. Nov 18, 2008
  20. Oct 18, 2008
  21. Sep 13, 2008
  22. Sep 10, 2008
  23. Sep 03, 2008
  24. Jul 03, 2008
  25. Jul 02, 2008
  26. Jun 28, 2008
  27. Jun 12, 2008
    • Becky Bruce's avatar
      Change initdram() return type to phys_size_t · 9973e3c6
      Becky Bruce authored
      
      This patch changes the return type of initdram() from long int to phys_size_t.
      This is required for a couple of reasons: long int limits the amount of dram
      to 2GB, and u-boot in general is moving over to phys_size_t to represent the
      size of physical memory.  phys_size_t is defined as an unsigned long on almost
      all current platforms.
      
      This patch *only* changes the return type of the initdram function (in
      include/common.h, as well as in each board's implementation of initdram).  It
      does not actually modify the code inside the function on any of the platforms;
      platforms which wish to support more than 2GB of DRAM will need to modify
      their initdram() function code.
      
      Build tested with MAKEALL for ppc, arm, mips, mips-el. Booted on powerpc
      MPC8641HPCN.
      
      Signed-off-by: default avatarBecky Bruce <becky.bruce@freescale.com>
      9973e3c6
  28. Jun 03, 2008
    • Stefan Roese's avatar
      ppc4xx: Remove superfluous dram_init() call or replace it by initdram() · bbeff30c
      Stefan Roese authored
      
      Historically the 405 U-Boot port had a dram_init() call in early init
      stage. This function was still called from start.S and most of the time
      coded in assembler. This is not needed anymore (since a long time) and
      boards should implement the common initdram() function in C instead.
      
      This patch now removed the dram_init() call from start.S and removes the
      empty implementations that are scattered through most of the 405 board
      ports. Some older board ports really implement this dram_init() though.
      These are:
      
      csb272
      csb472
      ERIC
      EXBITGEN
      W7OLMC
      W7OLMG
      
      I changed those boards to call this assembler dram_init() function now
      from their board specific initdram() instead. This *should* work, but please
      test again on those platforms. And it is perhaps a good idea that those
      boards use some common 405 SDRAM initialization code from cpu/ppc4xx at
      some time. So further patches welcome here.
      
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      bbeff30c
  29. May 20, 2008
    • Wolfgang Denk's avatar
      Big white-space cleanup. · 53677ef1
      Wolfgang Denk authored
      
      This commit gets rid of a huge amount of silly white-space issues.
      Especially, all sequences of SPACEs followed by TAB characters get
      removed (unless they appear in print statements).
      
      Also remove all embedded "vim:" and "vi:" statements which hide
      indentation problems.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      53677ef1
  30. Apr 18, 2008
  31. Jan 12, 2008
    • Wolfgang Denk's avatar
      Fix linker scripts: add NOLOAD atribute to .bss/.sbss sections · 64134f01
      Wolfgang Denk authored
      
      With recent toolchain versions, some boards would not build because
      or errors like this one (here for ocotea board when building with
      ELDK 4.2 beta):
      ppc_4xx-ld: section .bootpg [fffff000 -> fffff23b] overlaps section .bss [fffee900 -> fffff8ab]
      
      For many boards, the .bss section is big enough that it wraps around
      at the end of the address space (0xFFFFFFFF), so the problem will not
      be visible unless you use a 64 bit tool chain for development. On
      some boards however, changes to the code size (due to different
      optimizations) we bail out with section overlaps like above.
      
      The fix is to add the NOLOAD attribute to the .bss and .sbss
      sections, telling the linker that .bss does not consume any space in
      the image.
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      64134f01
  32. Oct 31, 2007
    • Stefan Roese's avatar
      ppc4xx: Rework of 4xx serial driver (2) · 882ae412
      Stefan Roese authored
      
      Change all linker scripts to reference the changed driver name 4xx_uart.o.
      
      Note: In most cased all these explicit referencing of these object files
      in the linker scripts is not neccessary. Only for manually embedded
      environment into the U-Boot image, which is not done is most cases.
      
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      882ae412
  33. Jul 10, 2007
  34. Jul 09, 2007
  35. Jul 03, 2007
  36. Oct 08, 2006
  37. Sep 01, 2006
    • Marian Balakowicz's avatar
      Add support for a saving build objects in a separate directory. · f9328639
      Marian Balakowicz authored
      Modifications are based on the linux kernel approach and
      support two use cases:
      
        1) Add O= to the make command line
        'make O=/tmp/build all'
      
        2) Set environement variable BUILD_DIR to point to the desired location
        'export BUILD_DIR=/tmp/build'
        'make'
      
      The second approach can also be used with a MAKEALL script
      'export BUILD_DIR=/tmp/build'
      './MAKEALL'
      
      Command line 'O=' setting overrides BUILD_DIR environent variable.
      
      When none of the above methods is used the local build is performed and
      the object files are placed in the source directory.
      f9328639
Loading