Skip to content
Snippets Groups Projects
Commit 0544c636 authored by Alessio Centazzo's avatar Alessio Centazzo Committed by Ben Warren
Browse files

ppc4xx: Fixed compilation warning in 4xx_enet.c


This patch fixes a compilation warning for some Ethernet PHY-less
PPC4xx platforms (440SPE based ones) and a potential compilation
error for 440SP platforms (use of undefined 'ethgroup' variable).
In the original code and in case of 440SPE platforms, 'ethgroup'
is initialized to -1 and never modified.  Later in the function,
within an #ifdef statement, an 'if statement' executes code only
if 'ethgroup' is set to 4, therefore it is harmless to avoid
executing the 'if statement' by removing the CONFIG_440SPE from
the affected #ifdefs.  In case of 440SP platforms  with on-board
Ethernet PHY, 'ethgroup' is undefined but used (there are not such
platforms in the repository yet). All other architectures are not
affected by this change.

Signed-off-by: default avatarAlessio Centazzo <acpatin@yahoo.com>
Acked-by: default avatarStefan Roese <sr@denx.de>
Signed-off-by: default avatarBen Warren <biggerbadderben@gmail.com>
parent 09133f85
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment