Skip to content
Snippets Groups Projects
  • Anatolij Gustschin's avatar
    23afaba6
    net: tsec: Fix Marvell 88E1121R phy init · 23afaba6
    Anatolij Gustschin authored
    
    This patch tries to ensure that phy interrupt pin
    won't be asserted after booting. We experienced
    following issues with current 88E1121R phy init:
    
    Marvell 88E1121R phy can be hardware-configured
    to share MDC/MDIO and interrupt pins for both ports
    P0 and P1 (e.g. as configured on socrates board).
    Port 0 interrupt pin will be shared by both ports
    in such configuration. After booting Linux and
    configuring eth0 interface, port 0 phy interrupts
    are enabled. After rebooting without proper eth0
    interface shutdown port 0 phy interrupts remain
    enabled so any change on port 0 (link status, etc.)
    cause assertion of the interrupt. Now booting Linux
    and configuring eth1 interface will cause permanent
    phy interrupt storm as the registered phy 1 interrupt
    handler doesn't acknowledge phy 0 interrupts. This
    of course should be fixed in Linux driver too.
    
    Signed-off-by: default avatarAnatolij Gustschin <agust@denx.de>
    Acked-by: default avatarAndy Fleming <afleming@freescale.com>
    Signed-off-by: default avatarBen Warren <biggerbadderben@gmail.com>
    23afaba6
    History
    net: tsec: Fix Marvell 88E1121R phy init
    Anatolij Gustschin authored
    
    This patch tries to ensure that phy interrupt pin
    won't be asserted after booting. We experienced
    following issues with current 88E1121R phy init:
    
    Marvell 88E1121R phy can be hardware-configured
    to share MDC/MDIO and interrupt pins for both ports
    P0 and P1 (e.g. as configured on socrates board).
    Port 0 interrupt pin will be shared by both ports
    in such configuration. After booting Linux and
    configuring eth0 interface, port 0 phy interrupts
    are enabled. After rebooting without proper eth0
    interface shutdown port 0 phy interrupts remain
    enabled so any change on port 0 (link status, etc.)
    cause assertion of the interrupt. Now booting Linux
    and configuring eth1 interface will cause permanent
    phy interrupt storm as the registered phy 1 interrupt
    handler doesn't acknowledge phy 0 interrupts. This
    of course should be fixed in Linux driver too.
    
    Signed-off-by: default avatarAnatolij Gustschin <agust@denx.de>
    Acked-by: default avatarAndy Fleming <afleming@freescale.com>
    Signed-off-by: default avatarBen Warren <biggerbadderben@gmail.com>