Skip to content
Snippets Groups Projects
  • Anton Staaf's avatar
    155cfb5e
    common: fix behavior of ROUND macro when input is already rounded · 155cfb5e
    Anton Staaf authored
    Currently when you call ROUND with a value that is already a
    multiple of the second parameter it will return a value that is
    one multiple larger, instead of returning the value passed in.
    
    There are only two types of usage of ROUND currently, one in
    various config files to round CONFIG_SYS_MALLOC_LEN to a multiple
    of 4096 bytes.  The other in cmd_sf.c where the incorrect behavior
    of ROUND is worked around be subtracting one from the length argument
    before passing it to ROUND.
    
    This patch fixes ROUND and removes the workaround from cmd_sf.  It
    also results in all of the malloc pools that use ROUND to compute
    their size shrinking by 4KB.
    
    Cc: Lukasz Majewski <l.majewski@samsung.com>
    Cc: Mike Frysinger <vapier@gentoo.org>
    155cfb5e
    History
    common: fix behavior of ROUND macro when input is already rounded
    Anton Staaf authored
    Currently when you call ROUND with a value that is already a
    multiple of the second parameter it will return a value that is
    one multiple larger, instead of returning the value passed in.
    
    There are only two types of usage of ROUND currently, one in
    various config files to round CONFIG_SYS_MALLOC_LEN to a multiple
    of 4096 bytes.  The other in cmd_sf.c where the incorrect behavior
    of ROUND is worked around be subtracting one from the length argument
    before passing it to ROUND.
    
    This patch fixes ROUND and removes the workaround from cmd_sf.  It
    also results in all of the malloc pools that use ROUND to compute
    their size shrinking by 4KB.
    
    Cc: Lukasz Majewski <l.majewski@samsung.com>
    Cc: Mike Frysinger <vapier@gentoo.org>