Commit 0e4fbfba authored by Steven Stallion's avatar Steven Stallion Committed by Freddie Chopin
Browse files

rtos: better sanity checking for uCOS-III

This patch improves the OSRunning check. If the rtos_running check
fails, update_threads will return an error rather than attempt to update
the thread list using bad values.

Change-Id: I8614c325504d3a9ab19aebb6862b1fe445a0c8e7
Signed-off-by: default avatarSteven Stallion <>

Tested-by: jenkins
Reviewed-by: default avatarAndreas Fritiofson <>
parent e6fe4ddd
...@@ -300,6 +300,11 @@ static int uCOS_III_update_threads(struct rtos *rtos) ...@@ -300,6 +300,11 @@ static int uCOS_III_update_threads(struct rtos *rtos)
return retval; return retval;
} }
if (rtos_running != 1 && rtos_running != 0) {
LOG_ERROR("uCOS-III: invalid RTOS running value");
return ERROR_FAIL;
if (!rtos_running) { if (!rtos_running) {
rtos->thread_details = calloc(1, sizeof(struct thread_detail)); rtos->thread_details = calloc(1, sizeof(struct thread_detail));
if (rtos->thread_details == NULL) { if (rtos->thread_details == NULL) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment