1. 11 Jul, 2018 1 commit
    • Ken A. Redergård's avatar
      Fix H5Transport timeout issues (#116) · 807d64ed
      Ken A. Redergård authored
      * Fix H5Transport timeout issues
      This commit addresses timeout issues that sometimes occur when calling sd_rpc_open.
      The problem is identified to be in the transport layers.
      The issue is addressed by:
          - Improving the state machine in H5Transport and improving UartBoost implementation
          - Requiring latest version of Boost (1.67). This to make sure all fixes in Boost ASIO serialport are included.
      State machine
      The H5Transport is now waiting for the internal state machine to be ready before opening the serial port that sets state machine values.
      The state machine transitions cover more exit criterias and the order of evaluating the exit criterias are improved.
      Two new states are added: STATE_CLOSED and STATE_NO_RESPONSE. 
      The state machine enters STATE_CLOSED when the user close the transport.
      The state machine enters STATE_NO_RESPONSE when the device does not reply on packets sent after n number of retries.
      The new states are used to give a more precise return value from sd_rpc_open.
      toString methods on ExitCriterias based classes are added to simplify
      Integrations tests
      Integration tests for open close functionality has been added for pc-ble-driver, H5Transport and UartBoost.
      The integration tests are implemented with the use of Catch2, a header file library test framework.
      Initially Boost Test Library was used, but since we are considering moving away from Boost, we try not to add more Boost dependencies.
      The old test that tested the Boost serial port implementation is removed.
      Build system
      The Boost library file names made by jam (boost build system) has changed for Windows builds.
      For cmake to find the libraries one need to use a recent version of cmake.
      We have tested it with cmake 3.11 and set it as a requirement.
      Other changes
      * General changes to the source code:
          - Added const-ness where applicable
          - Where applicable, changed pointers to type pointed to or *_ptr
          - Made payload into an alias (from std::vector<uint8_t>)
          - Expose methods and functions to facilitate integration testing
          - Typedefs changes to using
          - Changed callback names to make it clearer if callback was intended for local transport or upper transport
      Branch workflow
      We are now changing the pc-ble-driver git workflow.
      Fixes and improvements that are relevant for all major versions of the driver are fixed in master then cherry picked into the major version branches.
      To get to this state, this commit contains cherry picked commits from different branches.
      Here is a table of cherry picked commits:
      Uart boost fixes:
      H5Transport fixes:
      Spurious wakeup fixes and state machine fixes:
  2. 18 May, 2018 2 commits
  3. 09 Apr, 2018 3 commits
  4. 12 Mar, 2018 1 commit
  5. 11 Mar, 2018 1 commit
  6. 14 Feb, 2018 3 commits
  7. 09 Feb, 2018 1 commit
  8. 08 Feb, 2018 1 commit
  9. 18 Jan, 2018 1 commit
  10. 16 Jan, 2018 1 commit
  11. 18 Dec, 2017 5 commits
  12. 29 Nov, 2017 2 commits
  13. 28 Nov, 2017 17 commits
  14. 08 Nov, 2017 1 commit